fix: miner wallet setup for mandatory wallet_name + Bitcoin Core >= 25 support - #1877
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to stacks-network/stacks-core#7433: burnchain.wallet_name is now mandatory for miners, and the node loads (never creates) the wallet.
The miner guides now provision a watch-only descriptor wallet (
disable_private_keys=true) and import the publiccombo(...)descriptor of the miner key: the stacks node signs its bitcoin transactions itself, so no private key is stored in bitcoind. This replaces the previous createwallet + importprivkey flow, which is broken on Bitcoin Core ≥ 29.Every documented command was executed against the latest minor of every Core major from 25 through 31, and
stacks-corenow has an integration test stacks-network/stacks-core@8692f3e that pins the current guide commands for each new major version of bitcoin.